- Notifications
You must be signed in to change notification settings - Fork 5.4k
Created Image classification tutorial #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created Image classification tutorial #101
Conversation
| Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
| I signed it! |
| CLAs look good, thanks! |
| Very nice, thank you! A couple of quick things I see:
|
| Ok thank you .. i will do that |
| @lamberta about images in your 3rd point.. in the tutorials/images section there are use cases for CIFAR-10 and ImageNet.. does that mean i will have to only use either of them? or meant something else? |
| I re-checked the book and even in the book, the image dataset used is of cats vs dogs, but there, a local directory path is used for that, but its the same dataset i used here in the tutorial only located in remote server so that anyone can download and use. |
| We're fine with using other datasets, we just don't want to host them on tensorflow.org :) |
| The link to the images I used came from one of the notebook available in Google official github repo. Here is the link: Even in this notebook it is only mentioned that the original dataset is from kaggle: Will this work? |
| Thank you for the context. We need to discuss some things and come back to this. One issue is the use of the the keras-preprocessing package for your While this is definitely useful, and I think a lot of people will find it helpful, we can't quite present this as an official example. But, maybe we can create a community section (or something like that) ... but then that opens a different set of questions. We'll discuss further and see if we can come up with something. Thanks |
lamberta left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to discuss how keras-preprocessing and keras-applications examples fit in.
| Sure, I am happy to replace ImageDataGenerator with tf.data api if required. Please let me know what other changes you might need in this notebook and I am happy to do so. |
| @lamberta if I need to remove keras.preprocessing, I am considering using opencv and numpy to first load and resize the data and use tf.data api to make the generators.. so just wanted to check if this approach is acceptable for this tutorial? |
| Re: the ImageDataGenerator living elsewhere, my vote is to move this into core. Data augmentation (especially for images) is something basically every developer will need to do. Do we have an canonical utility with similar functionality? If not, I suggest we use these, they're proven. If they need to be rewritten to be backed by tf.data or similar, worth it. Also in favor of adding this to our official tutorials, rather than a community section, after a bit more cleanup. |
| @kshitizrimal, please hold off on re-writing that (hoping we can find a standard solution, so everyone doesn't need to roll their own for a common task like this). |
@random-forests sure, just let me know when its all sort out and I will make the changes accordingly. |
| Sorry about the delay here. We have talked with the owners, and they agree that if We might re-organize/edit the content a little (maybe break it into smaller documents). But let's not do that in this PR. I'm going to merge this, It won't be visible on the site immediately but I'll post back here when it is. |
I have created Image classification tutorial using TF.Keras and ImageDataGenerator class, of which I am an owner. Please have a look and if everything is fine with the tutorial, I would like to make this pull request.