- Notifications
You must be signed in to change notification settings - Fork 80
Update Button Overview #646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @yordan-mitev, Check the below option if you would like to automatically generate PR to production. The automation uses the branch for the cherry-pick, and then will delete the branch. Please, do not delete it manually.
|
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's agree on the following topics before committing the other Overview pages (see the other comments and suggestions) -
- slug naming convention
- PREVIEW tab instructions
- suggest theme change as a component styling customization
- component reference section - title and example
Sounds good. I will apply these suggestions to the rest of the Overview pages as well. |
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
* docs: update button overview.md * docs: address review comments * Apply suggestions from code review Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com> Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
* docs: Document GridEditMode.None and TreeListEditMode.None * docs: document ContextMenu OnClick and k class changes * Update Button Overview (#646) * docs: update button overview.md * docs: address review comments * Apply suggestions from code review Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com> Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com> * docs: Document button style changes * docs: Document button style changes 2 * docs: Breaking changes language improvements * docs: DrawerContent Breaking change * docs: Window and Loader Size breaking change * docs: Window Size breaking change * docs: Breaking changes sections and table formatting Co-authored-by: Dimo Dimov <dimo@Dimos-MacBook-Pro.local> Co-authored-by: Yordan <60105689+yordan-mitev@users.noreply.github.com>
This PR updates the Button component Overview page according to the guidelines in this document.
The Button is one of the ten initial components that will undergo this transformation.