Skip to content

Conversation

yordan-mitev
Copy link
Contributor

This PR updates the Button component Overview page according to the guidelines in this document.

The Button is one of the ten initial components that will undergo this transformation.

@yordan-mitev yordan-mitev requested a review from a team December 20, 2021 09:23
@github-actions
Copy link
Contributor

Hello @yordan-mitev,

Check the below option if you would like to automatically generate PR to production. The automation uses the branch for the cherry-pick, and then will delete the branch. Please, do not delete it manually.

  • create pr to production
@dimodi dimodi self-requested a review January 5, 2022 13:42
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Copy link
Contributor

@dimodi dimodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's agree on the following topics before committing the other Overview pages (see the other comments and suggestions) -

  • slug naming convention
  • PREVIEW tab instructions
  • suggest theme change as a component styling customization
  • component reference section - title and example
@yordan-mitev
Copy link
Contributor Author

Let's agree on the following topics before committing the other Overview pages (see the other comments and suggestions) -

  • slug naming convention
  • PREVIEW tab instructions
  • suggest theme change as a component styling customization
  • component reference section - title and example

Sounds good. I will apply these suggestions to the rest of the Overview pages as well.

Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
@yordan-mitev yordan-mitev requested a review from dimodi January 5, 2022 15:27
@dimodi dimodi merged commit 7d963df into master Jan 11, 2022
@github-actions github-actions bot deleted the docs-update-button-overview branch January 11, 2022 19:39
dimodi added a commit that referenced this pull request Jan 11, 2022
* docs: update button overview.md * docs: address review comments * Apply suggestions from code review Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com> Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
dimodi added a commit that referenced this pull request Jan 13, 2022
* docs: Document GridEditMode.None and TreeListEditMode.None * docs: document ContextMenu OnClick and k class changes * Update Button Overview (#646) * docs: update button overview.md * docs: address review comments * Apply suggestions from code review Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com> Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com> * docs: Document button style changes * docs: Document button style changes 2 * docs: Breaking changes language improvements * docs: DrawerContent Breaking change * docs: Window and Loader Size breaking change * docs: Window Size breaking change * docs: Breaking changes sections and table formatting Co-authored-by: Dimo Dimov <dimo@Dimos-MacBook-Pro.local> Co-authored-by: Yordan <60105689+yordan-mitev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants