Skip to content

Conversation

NansiYancheva
Copy link
Contributor

No description provided.

@dimodi dimodi marked this pull request as ready for review February 19, 2024 14:14
@dimodi dimodi requested a review from a team as a code owner February 19, 2024 14:14
@dimodi dimodi added the merge-to-production Use this label to get a comment to choose whether to merge the PR to production label Feb 19, 2024
Copy link
Contributor

Hello @dimodi,

Check the below option if you would like to automatically generate PR to production. The automation uses the branch for the cherry-pick, and then will delete the branch. Please, do not delete it manually.

  • create PR to production
NansiYancheva and others added 8 commits February 19, 2024 16:18
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
NansiYancheva and others added 5 commits February 19, 2024 16:19
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Copy link
Contributor

Here you are the link to your PR to production: 1940

@github-actions github-actions bot deleted the chart-customlegendkb branch February 19, 2024 14:24
Copy link
Contributor

@ikoevska ikoevska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed.


To use a custom Chart legend, you need to:

1. Disable the built-in legend with `<ChartLegend Visible="false" />`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need some ending punctuation here.

1. Disable the built-in legend with `<ChartLegend Visible="false" />`
1. Define specific colors for the Chart series or data points [through `Color` or `ColorField`]({%slug components/chart/types/column%}).
1. Implement the custom legend UI outside the Chart.
1. Use the same Chart series or data point colors in custom Chart legend.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Use the same Chart series or data point colors in custom Chart legend.
1. Use the same Chart series or data point colors in the custom Chart legend.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-to-production Use this label to get a comment to choose whether to merge the PR to production

3 participants