AppBar documentation #1749
Merged
AppBar documentation #1749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
dimodi reviewed Nov 14, 2023
dimodi reviewed Nov 14, 2023
dimodi reviewed Nov 14, 2023
dimodi reviewed Nov 14, 2023
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
dimodi reviewed Nov 14, 2023
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
dimodi reviewed Nov 14, 2023
dimodi reviewed Nov 14, 2023
dimodi reviewed Nov 14, 2023
dimodi reviewed Nov 14, 2023
dimodi reviewed Nov 14, 2023
| | ||
| | Method | Description | | ||
| |---------|-------------| | ||
| | `Refresh` | Use the method to programmatically re-render the AppBar. | |
There was a problem hiding this comment.
When will this be necessary?
dimodi reviewed Nov 14, 2023
dimodi reviewed Nov 14, 2023
dimodi reviewed Nov 14, 2023
dimodi reviewed Nov 14, 2023
| | ||
| private List<string> ThemeColors { get; set; } = new List<string>() | ||
| { | ||
| "base", |
There was a problem hiding this comment.
Better use the static constants, as we want to encourage customers to do the same.
dimodi reviewed Nov 14, 2023
dimodi reviewed Nov 14, 2023
dimodi reviewed Nov 14, 2023
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
dimodi reviewed Nov 14, 2023
dimodi reviewed Nov 14, 2023
dimodi reviewed Nov 14, 2023
dimodi reviewed Nov 14, 2023
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
components/appbar/overview.md Outdated
| --- | ||
| title: Overview | ||
| page_title: AppBar Overview | ||
| description: Overview of the AppBar component for Blazor. |
There was a problem hiding this comment.
This is probably a placeholder that must be replaced with a more detailed description.
components/appbar/overview.md Outdated
| | ||
| 1. Add the `<TelerikAppBar>` tag to a Razor file. | ||
| 1. Use the `<AppBarSection>` child tag to add content to the AppBar component. | ||
| (optional) Use [content dividers](#content-dividers) to add visual distinction between the sections in the AppBar. |
There was a problem hiding this comment.
Suggested change
| (optional) Use [content dividers](#content-dividers) to add visual distinction between the sections in the AppBar. | |
| 1. (optional) Use [content dividers](#content-dividers) to add visual distinction between the sections in the AppBar. |
| --- | ||
| title: Appearance | ||
| page_title: AppBar Appearance | ||
| description: Appearance settings of the AppBar for Blazor. |
There was a problem hiding this comment.
Use detailed descriptions with a length of around 150 symbols. This is more like a placeholder.
There was a problem hiding this comment.
It is not, do you have a suggestion for a better description? The feature itself is rather small
components/appbar/separators.md Outdated
| | Parameter | Type and Default Value | Description | | ||
| | ----------- | ----------- | ----------- | | ||
| | `Class` | `string` | The CSS class that will be rendered on the main wrapping element of the AppBar spacer. You could use that class to cascade styles. | | ||
| | `Size` | `string` | The width of the spacer. If you add an `AppBarSpacer` tag without Size the spacer will take all available space between the [Sections]({%slug appbar-sections%}). | |
There was a problem hiding this comment.
Suggested change
| | `Size` | `string` | The width of the spacer. If you add an `AppBarSpacer` tag without Size the spacer will take all available space between the [Sections]({%slug appbar-sections%}). | | |
| | `Size` | `string` | The width of the spacer. If you add an `AppBarSpacer` tag without Size, the spacer will take all available space between the [Sections]({%slug appbar-sections%}). | |
Co-authored-by: Yordan <60105689+yordan-mitev@users.noreply.github.com>
Co-authored-by: Yordan <60105689+yordan-mitev@users.noreply.github.com>
Co-authored-by: Yordan <60105689+yordan-mitev@users.noreply.github.com>
Co-authored-by: Yordan <60105689+yordan-mitev@users.noreply.github.com>
Co-authored-by: Yordan <60105689+yordan-mitev@users.noreply.github.com>
Co-authored-by: Yordan <60105689+yordan-mitev@users.noreply.github.com>
dimodi approved these changes Nov 14, 2023
Co-authored-by: Yordan <60105689+yordan-mitev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.