Skip to content

Conversation

@ben1009
Copy link
Contributor

@ben1009 ben1009 commented Sep 22, 2025

  • run cargo clippy --workspace --all-targets --all-features -- -D warnings
  • add rustfmt.toml & run fmt
  • add check, test, codecov GHA
image
@ben1009 ben1009 marked this pull request as draft September 22, 2025 08:54
@tekaratzas
Copy link
Owner

Thanks for the PR!

Want to add that clippy command to the workflow as well?

@ben1009
Copy link
Contributor Author

ben1009 commented Sep 22, 2025

Thanks for the PR!

Want to add that clippy command to the workflow as well?

yes, so it's converted as draft, wiil submitt later along with other changes.

@ben1009 ben1009 marked this pull request as ready for review September 23, 2025 02:57
@ben1009
Copy link
Contributor Author

ben1009 commented Sep 23, 2025

Test / coverage (pull_request) fail with error error - 2025-09-23 12:31:02,773 -- Upload failed: {"message":"Token required - not valid tokenless upload"}
need setup the cov token in repo setting

image
@tekaratzas
Copy link
Owner

Not familiar with CodeCov! Looking through it now.

Also apologies got a few conflicts from merging another PR.

Overall love the action here. Really want to get this in

@ben1009
Copy link
Contributor Author

ben1009 commented Sep 26, 2025

Not familiar with CodeCov! Looking through it now.

Also apologies got a few conflicts from merging another PR.

Overall love the action here. Really want to get this in

done
image

@ben1009
Copy link
Contributor Author

ben1009 commented Sep 30, 2025

image

@tekaratzas better get this pr merged if you got time, thanks

@tekaratzas
Copy link
Owner

Hey apologies for the delay.

Not super keen on getting the codecov key tbh. Feel it may be overkill and don't want to add a bunch of API dependencies at this point.

Would you be ok removing it for now? Otherwise this looks great.

@ben1009
Copy link
Contributor Author

ben1009 commented Oct 4, 2025

Hey apologies for the delay.

Not super keen on getting the codecov key tbh. Feel it may be overkill and don't want to add a bunch of API dependencies at this point.

Would you be ok removing it for now? Otherwise this looks great.

done
image

@tekaratzas
Copy link
Owner

Amazing, thanks for sticking with this!

@tekaratzas tekaratzas merged commit cf1f7d3 into tekaratzas:main Oct 5, 2025
4 checks passed
@ben1009 ben1009 deleted the housekeeping branch October 6, 2025 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants