Merge changes from swan-integration #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: Akash Ravi <akashkravi@gmail.com>
Signed-off-by: Akash Ravi <akashkravi@gmail.com>
diocas reviewed Sep 11, 2019
| | ||
| #package-name { | ||
| width: 390px; | ||
| width: 380px; |
There was a problem hiding this comment.
do you need to have this with fixed size?
There was a problem hiding this comment.
Having a 100% width seems to break the searchbar's dimensions. I'll check if there is any better alternative, compared to hardcoding the width.
| Any news? |
Signed-off-by: Akash Ravi <akashkravi@gmail.com>
| Let me know when this can be merged |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Akash Ravi akashkravi@gmail.com