Issue 106: ZeroDivisionError while preprocessing #109
Merged
+17 −23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added 2 commits February 5, 2021 12:11
…FeaturesForDirsList`, removed shaddowing of python3 core `dir`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
addresses #106.
TMP_DIR was not set correctly and caused files created in the wrong directory.
The tmp dir path in ExtractFeaturesForDir should be
"/tmp/feature_extractorXXXX"but was"".This lead to empty
*.rar.txtfiles.Which finally causes the ZeroDivisionError.