Skip to content

Fixes AWS launch config sorting #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lotas merged 1 commit into from
Sep 1, 2025
Merged

Fixes AWS launch config sorting #306

lotas merged 1 commit into from
Sep 1, 2025

Conversation

@lotas
Copy link
Contributor

@lotas lotas commented Sep 1, 2025

This fixes this error we saw while generating community-tc config:

 File "venv/lib/python3.13/site-packages/tcadmin/resources/worker_pool.py", line 38, in _sort_launch_configs config["launchConfigs"].sort(key=sort_key) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^ TypeError: '<' not supported between instances of 'NoneType' and 'NoneType'
@lotas lotas requested a review from a team as a code owner September 1, 2025 10:59
Eijebong
Eijebong approved these changes Sep 1, 2025
View reviewed changes
Copy link
Contributor

@Eijebong Eijebong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.
@lotas lotas merged commit 9e84798 into main Sep 1, 2025
2 checks passed
@lotas lotas deleted the feat/lc-sort-aws branch September 1, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@lotas @Eijebong