Add limited fifo ttl queue #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Kasen reviewed Jul 11, 2019
queue/abstract/driver/limfifottl.lua Outdated
| return nil | ||
| end | ||
| | ||
| local started = fiber.time64() |
Contributor
There was a problem hiding this comment.
I think time64 is redundant, and I prefer to use fiber.time().
queue/abstract/driver/limfifottl.lua Outdated
| timeout = timeout * 1000000 | ||
| | ||
| while true do | ||
| local tube_size = self.space:count() |
Contributor
There was a problem hiding this comment.
self.space:len() is more preferable here, because it is faster, but has less precision.
queue/abstract/driver/limfifottl.lua Outdated
| -- put task in space | ||
| local put = function (self, data, opts) | ||
| local timeout = opts.timeout or 0 | ||
| timeout = timeout * 1000000 |
Contributor
There was a problem hiding this comment.
If fiber.time64() will be changed on fiber.time(), then this multiplication will be not needed.
queue/abstract/driver/limfifottl.lua Outdated
| end | ||
| | ||
| local started = fiber.time64() | ||
| fiber.yield() |
Contributor
There was a problem hiding this comment.
fiber.yield() may cause a big cpu load, so I prefer to use fiber.sleep(0.01)
Optimize limfifottl put cpu usage
Move len method from abstract to limfifottl
Kasen approved these changes Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.