dashboard: fix cluster overview for Grafana 11 #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Version below 2.22 rate graphs fail due to [1]. 1. grafana/grafana#71052
Before this patch, older Grafana 6 color scheme were used for overview panel. It was fine for Grafana from 8 to 10, but don't work properly with Grafana 11. After this patch, the panel works properly with Grafana 11 and newer. For Grafana 9 and 10 everything works fine, except for row coloring: only single cell is colored [1]. For Grafana 8 and older, table column hiding no longer works properly so it's simpler for us to treat it as unsupported since it's EOLed 1 year and 3 months ago [2]. 1. grafana/grafana#27542 2. https://endoflife.date/grafana Follows #234
oleg-jukovec approved these changes Oct 4, 2024
DifferentialOrange deleted the DifferentialOrange/gh-234-fix-table-on-new-versions branch Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
dashboard: fix cluster overview for Grafana 11
grafonnet doesn't fill up empty thresholds for hidden fields. After table code rework introduced in Grafana 11, empty thresholds result in panel crush.
Thanks to @0x501D for exploring the issue.
Closes #234
dashboard: use Grafana 11 color scheme in overview table
Before this patch, older Grafana 6 color scheme were used for overview panel. It was fine for Grafana from 8 to 10, but don't work properly with Grafana 11 [Figure 1]. After this patch, the panel works properly with Grafana 11 and newer [Figure 2]. For Grafana 9 and 10 everything works fine, except for row coloring: only single cell is colored [1, Figure 3]. For Grafana 8 and older, table column hiding no longer works properly so it's simpler for us to treat it as unsupported since it's EOLed 1 year and 3 months ago [2, Figure 4].
Figure 1:
Figure 2:
Figure 3:
Figure 4:
Follows #234