Fix rate graphs scale #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Use auto decimal scaling for most panels. The main motivation is bad scaling for low value panels with decimalsY1=0. After the patch, scaling for low values should be good enough. At the same time, if values became high, there shouldn't be any excessive decimals. The drawback is that sometimes Grafana auto scaling is aesthetically weird, like mixing 2 s, 1.5 s and 500 ms on the same axis.
Grafana revisions: - InfluxDB revision 18 [1], - Prometheus revision 18 [2], - InfluxDB TDG revision 7 [3], - Prometheus TDG revision 7 [4]. Changed: - Use auto decimal scaling for most panels (PR #213) Fixed: - Scaling for some low values panels (PR #213) 1. https://grafana.com/api/dashboards/12567/revisions/18/download 2. https://grafana.com/api/dashboards/13054/revisions/18/download 3. https://grafana.com/api/dashboards/16405/revisions/7/download 4. https://grafana.com/api/dashboards/16406/revisions/7/download
DifferentialOrange force-pushed the DifferentialOrange/fix-rate-graphs-scale branch from b5ca960 to 293901d Compare DifferentialOrange changed the title Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Use auto decimal scaling for most panels. The main motivation is bad scaling for low value panels with decimalsY1=0. After the patch, scaling for low values should be good enough.
Before
After
At the same time, if values became high, there shouldn't be any excessive decimals. The drawback is that sometimes Grafana auto scaling is aesthetically weird, like mixing 2 s, 1.5 s and 500 ms on the same axis.
Before
After
Before
After