Skip to content

WIP Customizing sections #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

WIP Customizing sections #209

wants to merge 1 commit into from

Conversation

palage4a
Copy link

@palage4a palage4a commented May 3, 2023 •
edited
Loading

If this pull request introduces support for new metrics, do not forget to

  • add Grafana panel;
  • run make update-tests to build new dashboard artifacts;
  • add example application code to generate non-null metrics;
  • attach a screenshot of a new panel to the PR description;
  • add new Telegraf tag key, if relevant,
    • to all telegraf.conf files,
    • to "Grafana dashboard" documentation page;
  • add alert example, if relevant,
    • to alerts.yml,
    • to "Alerting" documentation page;
  • update supported_metrics.md.

In any case, do not forget to

  • link an issue;
  • add a CHANGELOG entry;
  • update documentation guidelines;
  • update README guidelines.

Closes #207
@DifferentialOrange
Copy link
Member

Thank you for your patch. Solved by #211
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@palage4a @DifferentialOrange