Dockerize the API app #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
fabiosammy reviewed Nov 24, 2021
fabiosammy reviewed Nov 24, 2021
fabiosammy reviewed Nov 24, 2021
Contributor Author
| @fabiosammy thank you for the review, I addressed the comments, let me know what do you think. |
brunohcastro reviewed Dec 1, 2021
src/_boot/swagger.ts Outdated
| version: swagger.version, | ||
| }, | ||
| host: `${http.host}:${http.port}`, | ||
| host: `${swagger.host}:${http.port}`, |
Collaborator
There was a problem hiding this comment.
I think that just using the basePath: '/api' without any host would work, have you tried that?
Contributor Author
There was a problem hiding this comment.
@brunohcastro good catch, removing the host option did the trick. 886158f
fabiosammy approved these changes Dec 2, 2021
brunohcastro approved these changes Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I updated the docker-compose configuration to allow us to easily run the app with a
docker-compose up.I needed to add the
HOSTas0.0.0.0because the Swagger will be running in the same container as the API, and it will listen for requests to0.0.0.0instead oflocalhostinside the container.I also needed to add a new
SWAGGER_HOSTaslocalhostbecause when accessing the/api-docsin the host machine, a request to0.0.0.0(theHOSTenv variable) will not go from the host machine to the Docker container, it needs to request tolocalhost.I add
container_namewith thenode-api-boilerplateprefix to avoid conflicts with other Docker containers that the developer can have.I also added the
mongo-expressto make it easy to administrate the MongoDB accessinglocalhost:8081.