Skip to content

Conversation

woohm402
Copy link
Contributor

@woohm402 woohm402 commented May 22, 2025

Summary

Fixes #18114.

It Seems in apply-config-to-theme.ts#keyPathToCssProperty function the theme key is transformed as:

  • . is replaced with -
  • /([a-z])([A-Z])/ is replaced with $1-$2.toLowerCase()

However in theme.ts#resolve, when failed to find exact key, it only replaces

  • . is replaced with -

It seems the second transformation step is missing in theme.ts#resolve, causing inconsistencies when using camelCase or PascalCase theme keys.

Test plan

All unit tests pass, including the new test case covering this behavior.

@woohm402 woohm402 requested a review from a team as a code owner May 22, 2025 16:37
@woohm402
Copy link
Contributor Author

I haven’t thoroughly tested all possible edge cases, so there might be scenarios I missed.
If anything seems off or needs more coverage, I’d be happy to follow up 😀

@thecrypticace thecrypticace self-assigned this May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants