-
- Notifications
You must be signed in to change notification settings - Fork 226
Add support for twin.macro #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Hey @lightyen thanks for the PR ✌ Any updates on this? |
| @lightyen 🙌 Any idea when will this be merged? |
1 similar comment
| @lightyen 🙌 Any idea when will this be merged? |
| @puneetverma05 @locona @dotomaz y'all are pinging the wrong person, lightyen doesn't have the ability to merge into this repo Based on the maintainer @bradlc 's message in tailwindlabs/tailwindcss#7553
This leads me to believe that this PR might be unlikely to be merged as-is since it's hard-coding support for twins |
| To solve this for twin users until tailwindlabs/tailwindcss#7553 is resolved, might anyone want to package this branch into a separate vscode plugin and publish that? already 12k weekly downloads and a strong momentum, would do a lot of good |
| @cheapsteak I have attached a packaged vsix built at 28814af If you don't trust strangers on the internet, you may assemble and install the package yourself with the following: git clone https://github.com/lightyen/tailwindcss-intellisense cd tailwindcss-intellisense git fetch origin feature/twin.macro git checkout feature/twin.macro npm install npm run package code --install vscode-tailwindcss-0.4.4-0.vsix |
| I had some issues with that list of commands but here's what worked for me: git clone https://github.com/lightyen/tailwindcss-intellisense twin-intellisense && cd $_ git fetch origin feature/twin.macro && git checkout feature/twin.macro npm install npx vsce packageThen in vscode:
The suggestions work for every class except for unique features like twins additional variants and variant groups. |
| @ben-rogerson that is because I forgot npm requires run to do a script |
- Use yarn, because of "npm: maximum call stack size exceeded" ```sh cd packages/tailwindcss-language-service && yarn build cd - cd packages/tailwindcss-intellisense && yarn package --yarn cd - ```
|
EDIT: It seems that lightyen instead deleted the fork, and created a new project from scratch. https://github.com/lightyen/vscode-tailwindcss-twin does not seem to be a fork, and seem to be twin-macro related. I personally think this is a better approach, as twin.macro differences are many. (context: I was about to also start my own extension as I figured out that I wanted to replace most of the code in this extension.) ping @lightyen in case I said something wrong again. |
According to tailwindlabs/tailwindcss#7553 I try to add some code for twin.macro.