Don’t skip suggesting empty variant implementations #1352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
philipp-spiess approved these changes May 13, 2025
| // ^ | ||
| let completion = await document.completions({ line: 0, character: 23 }) | ||
| | ||
| expect(completion?.items.length).toBe(19236) |
There was a problem hiding this comment.
This seems like a very reasonable change, lol
There was a problem hiding this comment.
I know right? lololol
thecrypticace force-pushed the feat/no-skip-empty-variants branch from bef0c1e to c7995ae Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
A variant written like this wouldn't be suggested:
This is because it generates no additional selectors / at rules. These don't really make much sense but they're still technically valid so should still be available in completions.