feat/grid-instead-of-flex #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- less internal styling (padding, margin, etc.) - new Virtualized component for opt-in virtualization - table elements instead of div elements - [ ] make it adjustable - layout via grid-template-columns instead of width/min-width - hide: hideKey: string became hide: boolean - layout={{ fixedHeader: true }} - layout={{ resizedLayout: string }} - layout={{ onLayoutChange: (gridTemplateColumns: string) => void }} BREAKING CHANGE: …s, and window gets bigger, the stiff column does not take all space and there is whitespace
… (double click bug)
| 🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The main things that have changed:
--data-table-library_grid-template-columns(everything acceptable what a CSSgrid-template-columnsproperty would accept) onTableproperty when usinguseTheme()instead of width/min-width on eachBaseCell(see FEATURES/Layout stories)table,td,th) instead of div elements, but they can be transformed as div elements by usinglayout={{ isDiv: true }}(see MISC/Table story)hideKey: stringbecamehide: booleanon each HeaderCell/Cell,hiddenColumnsinlayoutnot necessary anymore (see FEATURES/Hide Column stories)layout={{ fixedHeader: true }}layout={{ resizedLayout: string }}andlayout={{ onLayoutChange: (gridTemplateColumns: string) => void }}instead of usingstring[]