Fix styling to match PEP8 in most places #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
keszybz requested changes Mar 13, 2017
systemd/journal.py Outdated
| | ||
| self.send = kwargs.pop('SENDER_FUNCTION', send) | ||
| self._extra = kwargs | ||
| self.mapPriority = self.map_priority |
Member
There was a problem hiding this comment.
No need to make this a field on the object. I think the following should work:
@staticmethod def map_priority(levelno): ... mapPriority = map_priority
wesleybowman force-pushed the PEP8_fixes branch from 9d0d1ad to d47fd74 Compare 
Member
| Looks OK. I'll squash the two patches though, since the second one is just a fixup right now. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This change is to update the styling within
journal.pyto be more consistent with PEP8.