Skip to content

ci: move the CI to GitHub Actions #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 13, 2022
Merged

ci: move the CI to GitHub Actions #104

merged 3 commits into from
Aug 13, 2022

Conversation

@mrc0mmand
Copy link
Member

@mrc0mmand mrc0mmand commented Mar 6, 2022

No description provided.

@mrc0mmand mrc0mmand force-pushed the ci-shenanigans branch 9 times, most recently from 0d5924f to 9563771 Compare March 6, 2022 18:17
@mrc0mmand mrc0mmand force-pushed the ci-shenanigans branch 3 times, most recently from f1be5c6 to b481b64 Compare March 6, 2022 18:30
@mrc0mmand
Copy link
Member Author

mrc0mmand commented Mar 6, 2022

@keszybz this should be almost ready to go. A couple of questions:

  1. Which python versions should we cover (for now)
  2. The tests currently fail with python 2.7 - should they get fixed or we don't care about 2.7 anymore?
@mrc0mmand mrc0mmand marked this pull request as ready for review March 6, 2022 18:33
@mrc0mmand
Copy link
Member Author

mrc0mmand commented Mar 6, 2022 •
edited
Loading 

2. The tests currently fail with python 2.7 - should they get fixed or we don't care about 2.7 anymore?

I see, the first test was easy enough to fix, but in the second case the original change actually broke python 2.7 compatibility. i.e. since 4c9a241 the code doesn't work on 2.7 anymore, since datetime.astimezone() requires argument on 2.7, whereas on 3.x it defaults to the local timezone. The rationale is even mentioned in the commit message, so it looks like we indeed don't care about 2.7 anymore :-)
@mrc0mmand mrc0mmand force-pushed the ci-shenanigans branch 2 times, most recently from c5af6a3 to 55731d1 Compare March 9, 2022 15:52
@mrc0mmand mrc0mmand requested a review from keszybz March 9, 2022 19:29
@mrc0mmand mrc0mmand marked this pull request as draft March 28, 2022 10:48
@mrc0mmand mrc0mmand force-pushed the ci-shenanigans branch 9 times, most recently from aa2ac4e to 3c9f282 Compare March 28, 2022 13:46
@mrc0mmand mrc0mmand force-pushed the ci-shenanigans branch 10 times, most recently from 383776c to c607380 Compare March 28, 2022 14:49
@mrc0mmand mrc0mmand marked this pull request as ready for review March 28, 2022 15:02
behrmann
behrmann reviewed Apr 14, 2022
View reviewed changes
Copy link
Contributor

@behrmann behrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. This would be a good step for #103.
jamacku
jamacku reviewed Aug 11, 2022
View reviewed changes
Copy link
Member

@jamacku jamacku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to run these workflows on push events as well?
Maybe adding Dependabot would make sense as well, to keep dependencies up to date?
keszybz
keszybz reviewed Aug 13, 2022
View reviewed changes
Copy link
Member

@keszybz keszybz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great.
.github/workflows/build.yml
"3.7",
"3.8",
"3.9",
"3.10",
Copy link
Member

@keszybz keszybz Aug 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to add 3.11 here…
Copy link
Member Author

@mrc0mmand mrc0mmand Aug 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hehe, yeah, it's been a while.
@keszybz keszybz merged commit 04ee44d into main Aug 13, 2022
@keszybz keszybz deleted the ci-shenanigans branch August 13, 2022 14:57
@mrc0mmand
Copy link
Member Author

mrc0mmand commented Aug 13, 2022

Would it make sense to run these workflows on push events as well? Maybe adding Dependabot would make sense as well, to keep dependencies up to date?

That's definitely on the TODO list.
@keszybz
Copy link
Member

keszybz commented Aug 13, 2022

  1. The tests currently fail with python 2.7 - should they get fixed or we don't care about 2.7

I see, the first test was easy enough to fix, but in the second case the original change actually broke python 2.7 compatibility. i.e. since 4c9a241 the code doesn't work on 2.7 anymore, since datetime.astimezone() requires argument on 2.7, whereas on 3.x it defaults to the local timezone. The rationale is even mentioned in the commit message, so it looks like we indeed don't care about 2.7 anymore :-)

I don't want to spend time on 2.7 myself, but if somebody comes up with a patch, I guess we'd merge it. If support for 2.7 is fully removed, then we should also drop the C parts, where actually there's a lot of code duplication for the old C API.
@keszybz keszybz linked an issue Aug 15, 2022 that may be closed by this pull request
Systemd version on Semaphore CI is still 204 #61
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants

@mrc0mmand @keszybz @behrmann @jamacku