Skip to content

Conversation

@rcgob
Copy link
Contributor

@rcgob rcgob commented Jul 28, 2023

No description provided.

@rcgob rcgob requested a review from pablorcum July 28, 2023 17:59
@rcgob rcgob linked an issue Jul 28, 2023 that may be closed by this pull request
@pablorcum pablorcum added the enhancement New feature or request label Aug 6, 2023
Copy link
Member

@pablorcum pablorcum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid using relative paths and build paths whenever required based on project object to make the execution of scripts robust and independent of the work directory when the user starts them.

@pablorcum pablorcum marked this pull request as ready for review August 7, 2023 13:43
@pablorcum pablorcum self-requested a review August 7, 2023 13:45
@pablorcum pablorcum dismissed their stale review August 7, 2023 13:46

Replacing with newer review.

Copy link
Member

@pablorcum pablorcum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please only replace the jpg logo with the png we talked about and then, it is ready to merge.

@pablorcum pablorcum merged commit e4947ee into master Aug 7, 2023
@pablorcum pablorcum deleted the enhancement-7-distribute-api-toolbox branch August 7, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

3 participants