Skip to content
This repository was archived by the owner on Nov 28, 2022. It is now read-only.

Upgrade slf4j and logback versions #24

Closed
ferhtaydn wants to merge 1 commit into from
Closed

Upgrade slf4j and logback versions #24

ferhtaydn wants to merge 1 commit into from

Conversation

@ferhtaydn
Copy link

@ferhtaydn ferhtaydn commented Nov 8, 2022

  • Upgrade slf4j to version 2.x.x and logback to 1.3.x
  • Upgrade other libraries and fix broken pieces.
@ferhtaydn
Copy link
Author

ferhtaydn commented Nov 8, 2022

Even there's no change in the code logic, unit tests are now failing on expected log message.

  • Expected:
    [2022-11-08 14:03:22.792] AWS-REQUEST-ID INFO TEST-LOGGER - TEST-MESSAGE \r\n
  • Extra:
    14:03:22.792 [main] INFO TEST-LOGGER - TEST-MESSAGE\n
java.lang.AssertionError: Expected: a string matching the pattern '^\[[0-9\-:\. ]{23}\] AWS-REQUEST-ID INFO TEST-LOGGER - TEST-MESSAGE \r\n$' but: was "[2022-11-08 14:03:22.792] AWS-REQUEST-ID INFO TEST-LOGGER - TEST-MESSAGE \r\n14:03:22.792 [main] INFO TEST-LOGGER - TEST-MESSAGE\n"
@johnchapin johnchapin closed this Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants

@ferhtaydn @johnchapin