unqlite:enable O_CLOEXEC explicit #166
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: wanggang26 <wanggang26@xiaomi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
Added O_CLOEXEC flag when opening files to ensure that file descriptors are automatically closed when executing child processes, thus preventing potential file descriptor leaks.
Changes Made:
Modified the open function to include the O_CLOEXEC flag when opening files.
Potential Scenarios:
Executing child processes: When a parent process opens a file and then spawns a child process, there is a possibility that the child process inherits the open file descriptors. Without the O_CLOEXEC flag, these file descriptors may remain open in the child process, leading to resource leaks and potential security vulnerabilities.