[LiveComponent] Trigger model:set if a prop changes on the server #1232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
weaverryan commented Oct 25, 2023
| } | ||
| | ||
| private function verifyChecksum(array $identifierPops, string $error = 'Invalid checksum sent when updating the live component.'): void | ||
| private function verifyChecksum(array $identifierProps, string $error = 'Invalid checksum sent when updating the live component.'): void |
Member Author
There was a problem hiding this comment.
Unrelated - just identified this typo.
weaverryan force-pushed the live-model-set-from-server branch from d82ee7a to fe3e16a Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hi!
If you use the
model:sethook, and a prop changes on the server during a re-render, when the Ajax call finishes,model:setwill now be called. Details:A) The code was a bit complex, but for writable sub-properties (
#[LiveProp(writable: 'firstName, 'lastName']above auserproperty),model:setis called for each sub-key that changes - e.g.user.firstNameanduser.lastName. That is consistent with the behavior if those were changed by the user (e.g. by typing into auser.firstNameinput).B) If the user changes a prop during the Ajax request (e.g. they type into
user.firstName), thenmodel:setwill not be triggered for this one model. That's because the "frontend value" takes precedence over any server updates (this has always been the case). And so, the end result is that, even if the server changeduser.firstName, after the Ajax call finishes, the actual value of that prop on the frontend will be whatever the user changed it to during the re-render.Cheers!