[DependencyInjection] Fix optimizing ClassExistenceResource #61615
+43 −28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nicolas-grekas force-pushed the di-fix branch from 63a0c79 to b7ca948 Compare 
HypeMC approved these changes Sep 3, 2025
stof reviewed Sep 3, 2025
| } | ||
| if ($resource instanceof ClassExistenceResource) { | ||
| $class = $resource->getResource(); | ||
| if (!$resource instanceof ClassExistenceResource) { |
There was a problem hiding this comment.
should we extract the check of ClassExistenceResource being in vendors into a private method instead of this early check of any other type ? It might reduce the risk of mistakes when wanting to optimize other Resource implementations in the future.
There was a problem hiding this comment.
let's see in the future :)
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Per @stof review at #57948 (review)
Best reviewed ignoring whitespaces.