[DependencyInjection] Exclude referencing service (self) in TaggedIteratorArgument

[chalasr]

Q	A
Branch?	6.3
Bug fix?	no
New feature?	yes
Deprecations?	no
Tickets	-
License	MIT
Doc PR	-

Suggested by @OskarStark in https://twitter.com/OskarStark/status/1594641457226436608?s=20&t=Wbqw_Mu2tMYQ0iouaG8yig.
This PR avoids the need to explicitly indicate to exclude the referencing service when using #[TaggedIterator] and variants.

Before:

final class DelegatingErrorTracker implements ErrorTracker { public function __construct( #TaggedIterator(ErrorTracker::class, exclude: self::class)] private iterable $trackers ) {} }

After:

final class DelegatingErrorTracker implements ErrorTracker { public function __construct( #TaggedIterator(ErrorTracker::class] private iterable $trackers ) {} }

I went with no deprecation as I think the breakage potential is close to zero, but happy to reconsider.

[OskarStark]

Uhh thanks for heading back 💪🏻 the good looks good as far as I can say

[stof]

this does not add support when creating such iterator arguments from Yaml or XML configs

[OskarStark]

Friendly ping @lyrixx

[chalasr]

this does not add support when creating such iterator arguments from Yaml or XML configs

ResolveTaggedIteratorArgumentPass covers any TaggedIteratorArgument no matter if it's wired by the yaml/xml/attribute file loader, isn't it?

[stof]

@chalasr the missing part is not the resolution. It is the support for the new argument added in the constructor ($autoExcludeReferencingService) where Yaml and XML files are currently unable to control it.

[chalasr]

Got it, thanks. Support added

[chalasr]

Rebased. Reviews welcome

[nicolas-grekas]

So, this changes the current behavior, but we're confident this won't break anyone, right?

[chalasr]

Yes, at least I am :)

[chalasr]

Anything else? :)

[fabpot]

Thank you @chalasr.