[2.8] [Form] fix tests added in #17798 with FQCN #17890
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
HeahDude commented Feb 22, 2016
HeahDude commented | Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | not yet |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | - |
- Rebase when [2.7] [Form] Fix BC break by allowing 'choice_label' option to be 'false' in ChoiceType #17798 get merged in 2.8
Merged
4 tasks
| Note for the merger : |
1 task
HeahDude changed the title fabpot added a commit that referenced this pull request Feb 28, 2016
…n to be 'false' in ChoiceType (HeahDude) This PR was merged into the 2.7 branch. Discussion ---------- [2.7] [Form] Fix BC break by allowing 'choice_label' option to be 'false' in ChoiceType | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #17773 | License | MIT | Doc PR | symfony/symfony-docs#6282 - [x] Make tests pass - [x] Adress a doc PR - [x] Replace alias by FQCN in tests for 2.8, see #17890 - [x] Remove `choices_as_values` in tests for 3.0, see #17891 Commits ------- 017e1d9 bug #17798 [Form] allow `choice_label` option to be `false`
| cherry-picked, thanks. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.