Skip to content

Fix "JsonSerializable" URL #9536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 4, 2018
Merged

Fix "JsonSerializable" URL #9536

merged 2 commits into from
Apr 4, 2018

Conversation

liviubalan
Copy link
Contributor

javiereguiluz
javiereguiluz requested changes Apr 1, 2018
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! However, the fix should be to use this:

:phpclass:`JsonSerializable`

Thanks!
@liviubalan
Copy link
Contributor Author

Done! Thanks for the info @javiereguiluz !
@javiereguiluz javiereguiluz added this to the 3.4 milestone Apr 4, 2018
@javiereguiluz javiereguiluz merged commit fbd87a6 into symfony:3.4 Apr 4, 2018
javiereguiluz added a commit that referenced this pull request Apr 4, 2018
@javiereguiluz
minor #9536 Fix "JsonSerializable" URL (liviubalan, Liviu Balan)
8c64e05 
This PR was merged into the 3.4 branch. Discussion ---------- Fix "JsonSerializable" URL Change generated URL "http://api.symfony.com/3.4/JsonSerializable.html" to "http://php.net/manual/en/class.jsonserializable.php" <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- fbd87a6 Changes after code review 5116cc3 Fix "JsonSerializable" URL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Reviewed

3 participants

@liviubalan @javiereguiluz @carsonbot