Skip to content

Conversation

dominikhajduk
Copy link
Contributor

@dominikhajduk dominikhajduk commented Mar 28, 2018

@dominikhajduk dominikhajduk changed the title Add information about internationalized routing [Routing] Add information about internationalized routing Mar 28, 2018
Copy link
Contributor

@DylanDelobel DylanDelobel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Symfony best practice recommend using Annotations, the code-block yaml should be after the php-annotations?

xml and php code-block missing, Otherwise, that looks good to me.

@xabbuh xabbuh added this to the 4.1 milestone Apr 19, 2018
@xabbuh
Copy link
Member

xabbuh commented Apr 19, 2018

Thank you for this PR @dominikhajduk. However I sadly have to close here as #9515 looks more complete. I hope to see you soon again with some other contribution.

@xabbuh xabbuh closed this Apr 19, 2018
@dominikhajduk
Copy link
Contributor Author

Sure no problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

4 participants