Update email field length in annotation (User class in security section) #9402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
I believe 60 characters for email is not enough, because maximum length of email is 254 chars. See https://stackoverflow.com/a/574698/3000493
Holicz changed the title 
| A minor but nice change! Thanks. We merged it on 2.7 branch because that's the oldest maintained branch (https://symfony.com/roadmap) |
javiereguiluz added a commit that referenced this pull request Mar 7, 2018
…curity section) (Holicz) This PR was submitted for the 4.0 branch but it was merged into the 2.7 branch instead (closes #9402). Discussion ---------- Update email field length in annotation (User class in security section) I believe 60 characters for email is not enough, because maximum length of email is 254 chars. See https://stackoverflow.com/a/574698/3000493 Commits ------- 8324c93 Update email field length in annotation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I believe 60 characters for email is not enough, because maximum length of email is 254 chars. See https://stackoverflow.com/a/574698/3000493