Controller naming habits #9282
Merged
Controller naming habits #9282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rzilin approved these changes Feb 17, 2018
| @Guikingone well spotted! This is not a hard requirement. |
javiereguiluz added a commit that referenced this pull request Feb 18, 2018
This PR was merged into the 4.0 branch. Discussion ---------- Controller naming habits As Symfony isn't an `MVC` framework but a `Request/Response` one (see #8153 (comment)), the name of the class which handles the Request isn't forced to contain `Controller`, it's probably more a common usage than a need to make Symfony works. Commits ------- 5b29f5b Minor reword 2b61e3b suggest(Controller): suggestion about naming habits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
As Symfony isn't an
MVCframework but aRequest/Responseone (see #8153 (comment)), the name of the class which handles the Request isn't forced to containController, it's probably more a common usage than a need to make Symfony works.