Missing return in the getDefaultOptions method

[jcrombez]

No description provided.

[stof]

@francisbrass returning the optiosn passed by the end-user kills one of the features of the Form component, which is validating that you pass only supported options (typos resulting in errors instead of being ignored). The method is really meant to return the default options, not to merge the options with the defaults.
Merging is handling in another part of the component already to build the final option array. So this change is the good one.

[jcrombez]

@stof : do you know why there is $options in argument ? It doesn't really make sense with the purpose of returning the default options value. It's a legacy from an old way of handling form options ?

[stof]

because some default values can depend of some other values passed by the user. Look at the choice type for instance. The default empty value depends of the multiple option.

[weaverryan]

Thanks guys!

Merged into the 2.0 branch at sha: 5479ba6

I had also wondered what the purpose of the incoming $options was, since you never see people returning it. I understand the reason why, but it is an unfortunate signature.

Thanks!

[francisbrass]

@stof : thank you for the info, I should have pay more attention :)