Update HttpCache kernel documentation for Symfony 4 #8696
Conversation
| I guess this is duplicated of #8682 ... these days we're updating all docs, so please check the open PR and create an issue saying that you are going to work on some files. Thanks! |
| Thanks @javiereguiluz . That's too bad because I checked but didn't see your PR, my bad. The cool thing is that @weaverryan proposes the same name for the caching kernel, so it seems its quite a natural one :) You can close this PR then if you wish! |
There was a problem hiding this comment.
@michaelperrin if you are able to make the suggested changes faster than Javier, then I would be happy to merge your's in. Javier's PR has additional changes - so he could just rebase after your merge. But, quick! Symfony 4 is upon us! :)
http_cache.rst Outdated
| To enable caching, modify the code of your front controller. You can also make these | ||
| changes to ``index.php`` to add caching to the ``dev`` environment:: | ||
| // src/CacheKernel.php | ||
| <?php |
| Modify the code of your front controller to wrap the default kernel into the | ||
| caching kernel:: | ||
| | ||
| // public/index.php |
There was a problem hiding this comment.
Let's change the :: to just : and add (on the next line) .. code-block:: diff.
Then, you can add + and - to emphasize the changes:
.. code-block:: diff // some line from before - // line to go away + // line to add There was a problem hiding this comment.
That's great advice, thanks :) I could check that everything is fine by compiling the doc with Sphinx.
michaelperrin force-pushed the fix/symfony4-http-cache-kernel branch from 865d565 to b15dba2 Compare | @weaverryan I made the changes you requested :) |
| Thank you Michaël! |
…chaelperrin) This PR was merged into the 4.0 branch. Discussion ---------- Update HttpCache kernel documentation for Symfony 4 #SymfonyConHackday2017 I am not entirely sure that we should document this way (creating a `src/CacheKernel.php` file as I propose here). Feel free to comment :) Commits ------- b15dba2 Update HttpCache kernel documentation for Symfony 4
4 participants
#SymfonyConHackday2017
I am not entirely sure that we should document this way (creating a
src/CacheKernel.phpfile as I propose here). Feel free to comment :)