Remove outdated performance tips #8556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Tobion commented Oct 29, 2017
| ------------------------------- | ||
| | ||
| Another solution is to cache the location of each class after it's located | ||
| the first time. Symfony comes with a class - :class:`Symfony\\Component\\ClassLoader\\ApcClassLoader` - |
There was a problem hiding this comment.
component deprecated
Tobion commented Oct 29, 2017
| .. index:: | ||
| single: Performance; Bootstrap files | ||
| | ||
| Use Bootstrap Files |
There was a problem hiding this comment.
not recommended anymore, esp. with php 7
There was a problem hiding this comment.
technically this is still relevant for php 5 (as you know), but I'm +1 for removing it... because users already have this code - PHP 5 users don't need to take any action.
Tobion commented Oct 29, 2017
| -------------------------------------- | ||
| | ||
| By default, the Symfony Standard Edition uses Composer's autoloader | ||
| in the `autoload.php`_ file. This autoloader is easy to use, as it will |
There was a problem hiding this comment.
Does not exist anymore since symfony/symfony-standard#1056
weaverryan approved these changes Oct 29, 2017
| .. index:: | ||
| single: Performance; Bootstrap files | ||
| | ||
| Use Bootstrap Files |
There was a problem hiding this comment.
technically this is still relevant for php 5 (as you know), but I'm +1 for removing it... because users already have this code - PHP 5 users don't need to take any action.
| Thanks @Tobion! |
weaverryan added a commit that referenced this pull request Oct 29, 2017
This PR was merged into the 3.3 branch. Discussion ---------- Remove outdated performance tips I've just realized there is an ongoing effort to rewrite this in #8410 and #7960. But if those are not merged soon, I'd suggest to merge this first so that we can at least solve the broken doc and people don't try to repeatedly fix this, like me and #8332 Commits ------- d21e200 Remove outdated performance tips
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I've just realized there is an ongoing effort to rewrite this in #8410 and #7960.
But if those are not merged soon, I'd suggest to merge this first so that we can at least solve the broken doc and people don't try to repeatedly fix this, like me and #8332