Skip to content

Conversation

javiereguiluz
Copy link
Member

This fixes #8412.

@xabbuh xabbuh added this to the 3.3 milestone Oct 3, 2017
performance because less services will be loaded into the container.

The default value is ``true`` when the project uses ``symfony/symfony`` as a
dependency. Otherwise, it defaults to ``false``.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect. The default is still disabled. The only case where it is automatically enabled is when you're using symfony/flex and symfony/form is required as well.

This also applies to assets, validation, translation, serialization and csrf. Can we add the note there as well?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, issue updated accordingly

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. So I think explaining the logic behind the default value is too complex and doesn't add much value. A more useful thing is to run debug:config framework. I think we should mention this command at the top of each reference, and remove the default value in cases where there is not a simple answer.

@javiereguiluz
Copy link
Member Author

Closed in favor of #8979.

javiereguiluz added a commit that referenced this pull request Jan 5, 2018
…k config (javiereguiluz) This PR was merged into the 4.0 branch. Discussion ---------- Fixed the default values for "enabled" option in framework config This takes over #8468 and it's made on 4.0 branch because this is our first "Flex only" branch in docs. Commits ------- 1ff35b2 Fixed the default values for "enabled" option in framework config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment