Skip to content

Update 3.3-di-changes.rst #8415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2017
Merged

Update 3.3-di-changes.rst #8415

merged 1 commit into from
Sep 22, 2017

Conversation

yceruto
Copy link
Member

@yceruto yceruto commented Sep 21, 2017

Now controllers tagged with controller.service_arguments are public true by definition symfony/symfony#24126
yceruto
yceruto commented Sep 21, 2017
View reviewed changes
service_container/3.3-di-changes.rst
// ...
// override default template
$definition->setPublic(true);
Copy link
Member Author

@yceruto yceruto Sep 21, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we are missing ->addTag('controller.service_arguments') ?
@xabbuh xabbuh added this to the 3.3 milestone Sep 22, 2017
@xabbuh
Copy link
Member

xabbuh commented Sep 22, 2017

Thank you @yceruto.
@xabbuh xabbuh merged commit 33b0ab8 into symfony:3.3 Sep 22, 2017
xabbuh added a commit that referenced this pull request Sep 22, 2017
@xabbuh
minor #8415 Update 3.3-di-changes.rst (yceruto)
ff80230 
This PR was merged into the 3.3 branch. Discussion ---------- Update 3.3-di-changes.rst Now controllers tagged with `controller.service_arguments` are public `true` by definition symfony/symfony#24126 Commits ------- 33b0ab8 Update 3.3-di-changes.rst
@yceruto yceruto deleted the patch-5 branch September 22, 2017 12:36
@yceruto yceruto mentioned this pull request Oct 16, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Reviewed

2 participants

@yceruto @xabbuh