-
- Notifications
You must be signed in to change notification settings - Fork 5.3k
[DX] ADR usage #8153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DX] ADR usage #8153
Changes from 1 commit
c8050b1 0d0d4cc 7359837 885e696 220021e 1fda263 11c77c7 d21feb2 a449220 6d1ed62 a81b625 8444e98 a93fa6c 97bcbac 72c2c74 666a89f c8625fb 0d2022a 582f4bf a237312 cd46501 24416f5 dc6ddc6 f1aad20 16c8472 eca9a0a aa0a207 551aed6 3dacc68 File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- Loading branch information
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| | @@ -108,31 +108,16 @@ build a HelloAction class that use the ADR principes :: | |
| use Symfony\Component\HttpFoundation\Response; | ||
| use Symfony\Component\Templating\EngineInterface; | ||
| | ||
| /** | ||
| * Class HelloAction | ||
| */ | ||
| final class HelloAction | ||
| { | ||
| /** @var EngineInterface */ | ||
| private $renderEngine; | ||
| | ||
| /** | ||
| * HelloAction constructor. | ||
| * | ||
| * @param EngineInterface $renderEngine | ||
| */ | ||
| private $render; | ||
| ||
| | ||
| public function __construct( | ||
| EngineInterface $renderEngine | ||
| EngineInterface $engine | ||
| ) { | ||
| ||
| $this->renderEngine = $renderEngine; | ||
| $this->renderEngine = $render; | ||
| ||
| } | ||
| | ||
| /** | ||
| * @throws \InvalidArgumentException | ||
| * @throws \RuntimeException | ||
| * | ||
| * @return Response | ||
| */ | ||
| public function __invoke() | ||
| { | ||
| return new Response( | ||
| | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This component is to be deprecated, a Twig
Environmentshould be used instead.