Stop recommending the use of "doctrine:generate:entities" #8119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
xabbuh reviewed Jul 5, 2017
doctrine.rst Outdated
| command to let Doctrine generate these getter/setter methods. However, this | ||
| is now considered a bad practice. This command doesn't handle edge cases, | ||
| doesn't generate methods for associactions and creates unnecesary backups of | ||
| PHP classes. |
There was a problem hiding this comment.
I am not sure if we need to have this block.
There was a problem hiding this comment.
There also is a typo in "associactions"
There was a problem hiding this comment.
I've removed it. Thanks!
xabbuh approved these changes Jul 5, 2017
oallain approved these changes Jul 5, 2017
| Thank you Javier. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This fixes #5070.