Added the command to install babel-preset for babel-loader #8058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
While testing this bundle i was getting hit by an erorr that i can't find the babel preset es2017 which i solved it by installing. I'm new to this webpack thing and to work like this with javascript. Some people might be in my position and try for hours to solve this. :D
weaverryan requested changes Jun 18, 2017
frontend/encore/babel.rst Outdated
| But first let's install the babel preset. | ||
| | ||
| ``yarn add babel-preset-es2017`` | ||
| This will install the preset that we will use later to configure the babel. |
There was a problem hiding this comment.
I think this is indeed a good clarification! But what about adding this information as comments in the code block below (right above the es2017 line. We can say something like:
// make sure to install any presets you want to use
// yarn add ...
| I hope it is ok now :). |
javiereguiluz approved these changes Jul 9, 2017
| @javiereguiluz yeap it's ok =D |
| Thank you @bogdaniel. |
xabbuh added a commit that referenced this pull request Jul 11, 2017
…r (bogdaniel, javiereguiluz) This PR was merged into the 3.3 branch. Discussion ---------- Added the command to install babel-preset for babel-loader While testing this bundle i was getting hit by an erorr that i can't find the babel preset es2017 which i solved it by installing. I'm new to this webpack thing and to work like this with javascript. Some people might be in my position and try for hours to solve this. :D Commits ------- b9edef8 Minor reword ab41baf Update babel.rst e74e556 Added the command to install babel-preset for babel-loader
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
While testing this bundle i was getting hit by an erorr that i can't find the babel preset es2017 which i solved it by installing.
I'm new to this webpack thing and to work like this with javascript. Some people might be in my position and try for hours to solve this. :D