Skip to content

Property access #7870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Property access #7870

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0ab59ab
Fix writing to objects example
iulyanp Apr 2, 2017
3c95b96
Delete extra parenthesis from decorator example
iulyanp Apr 2, 2017
4266a86
Update getLastName method
iulyanp May 4, 2017
5219674
Fix the example of modifying object
iulyanp May 5, 2017
2a61713
Fix codestyle
iulyanp May 5, 2017
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix codestyle
  • Loading branch information
@iulyanp
iulyanp committed May 5, 2017
commit 2a617134e76f00e658a86522a338f5659c0dd1af
14 changes: 8 additions & 6 deletions components/property_access.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,18 +252,20 @@ can use setters, the magic ``__set()`` method or properties to set values::
$this->lastName = $name;
Copy link
Contributor

@apfelbox apfelbox May 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should change this to return $this->lastName; then.
Copy link
Contributor Author

@iulyanp iulyanp May 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
}

public function __set($property, $value)
public function getLastName()
Copy link
Member

@xabbuh xabbuh May 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this change. This section is about modifying objects not reading from them.
Copy link
Contributor Author

@iulyanp iulyanp May 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks better.
{
$this->$property = $value;
}

public function getLastName() {
return $this->lastName;
}

public function getChildren() {
public function getChildren()
{
return $this->children;
}
Copy link
Member

@xabbuh xabbuh May 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move both methods between setLastName() and __set(). And to match the code style of the Symfony code the opening curly brace should be on its own line. However, we can easily make this change while merging your PR.

public function __set($property, $value)
{
$this->$property = $value;
}
}

$person = new Person();
Expand Down