Update service_decoration to offer decoration code sample #7586
Conversation
This update offer a decorator code sample for the 'app.mailer' service. This allow to the newcomers to fully understand the decorator principle.
| Suppose you want to process the text parts to send behind the ``app.mailer``, you will create a mailer decorator:: | ||
| | ||
| // AppBundle/DecoratingMailer.php | ||
| namespace AppBundle\DecoratingMailer; |
There was a problem hiding this comment.
To be consistent, the namespace should be only AppBundle.
There was a problem hiding this comment.
Oh, I've done a mistake. What about using :
- AppBundle\Decorator as namespace
- AppBundle/Decorator/DecoratingMailer.php as file
There was a problem hiding this comment.
If we were to add a namespace I think we should use Mailer. But then other examples would need an update too.
What do others think?
There was a problem hiding this comment.
We must provide the better practice to follow in the documentation examples and I think adding a namespace is a good practice in this context case. I'll update to AppBundle\Mailer tomorrow.
…Bundle\\Mailer namespace and be consistent with semantical bundle structure
| Update done for Mailer service/class namespace in service_container and DependencyInjection component |
| @matthieu88160 I'm sorry we didn't take care of your proposal on time. During the past months, the Symfony Docs team has decided to aggressively simplify everything because we don't have enough resources to maintain everything. In the past weeks we've deleted thousands of lines, even entire articles. About your specific changes, changing About the other proposal, I don't think it's necessary to display an example of the source code of the That's why I'm closing this as "won't fix" and I hope you understand why. Thanks! |
5 participants
This update offer a decorator code sample for the 'app.mailer' service. This allow to the newcomers to fully understand the decorator principle.