Add MicroKernelTrait advanced example run section #7570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
wouterj reviewed Mar 5, 2017
configuration/micro_kernel_trait.rst Outdated
| Then see webpage in browser: | ||
| | ||
| > http://localhost:8000/random/10 |
There was a problem hiding this comment.
This is markdown syntax. I realize this isn't your fault, as it's wrong above as well. Can you please update both lines to be something like:
Then visit the webpage in the browser: http://localhost:8000/random/10(actually, I really like to make these links clickable, but not sure what others think about that, so let's not do that in this PR)
| Thanks @wouterj. Updated both places and squashed to one commit. |
| Thanks for your PR and quick actions Dominik! |
wouterj added a commit that referenced this pull request Mar 7, 2017
…nikhajduk) This PR was merged into the 2.8 branch. Discussion ---------- Add MicroKernelTrait advanced example run section PR after [issue #7348](#7348) reported by @olberger. Improved [MicroKernel advanced example](http://symfony.com/doc/current/configuration/micro_kernel_trait.html#advanced-example-twig-annotations-and-the-web-debug-toolbar). Mentioned that build-in web server need to be run in `web/` directory. Commits ------- 6e9bb73 Add MicroKernelTrait advanced example run section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR after issue #7348 reported by @olberger.
Improved MicroKernel advanced example. Mentioned that build-in web server need to be run in
web/directory.