Improve example context #7563
Closed
Improve example context #7563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This commit add the component standalone examples and place the existing ones into a controller context.
Improve example context
HeahDude reviewed Mar 26, 2017
| { | ||
| public function newAction() | ||
| { | ||
There was a problem hiding this comment.
This blank line is useless.
| $form = $this->createFormBuilder($task) | ||
| ->setAction($this->generateUrl('target_route')) | ||
| ->setMethod('GET') | ||
| ->add('task', TextType::class) |
There was a problem hiding this comment.
This PR should target 2.7 and use type names (i.e 'text').
| Thank you @matthieu88160. |
xabbuh added a commit that referenced this pull request Apr 15, 2017
This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #7563). Discussion ---------- Improve example context This commit add the component standalone examples and place the existing ones into a controller context. (Framework example first) Commits ------- 901fe20 Fixed the RST syntax ce9db18 Improve example context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This commit add the component standalone examples and place the existing ones into a controller context. (Framework example first)