Resolving $this usage outside a class on form.rst #7560
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This commit take care of the framework use code examples only. The "Creating a simple Form" define the coding place to be into a controller action method. Unlikely, the documentation consider into the other examples that the reader will know the place of the sample code. This does not allow the examples to be standalone and can lead some disappointment for which one want to have informations about a single section. This commit offer to place the code samples into the default controller to create a logic use of the "$this" special variable.
HeahDude reviewed Mar 1, 2017
| $defaults = array( | ||
| 'dueDate' => new \DateTime('tomorrow'), | ||
| ); | ||
| $form = $this->createFormBuilder($defaults) |
There was a problem hiding this comment.
Since this documents the component maybe $this-> should be replaced by FormFactory:: with the proper use statement instead of the current proposal. What do you think?
There was a problem hiding this comment.
Ah yes forgot about my comment, this is a good fix!
HeahDude approved these changes Mar 1, 2017
| $defaults = array( | ||
| 'dueDate' => new \DateTime('tomorrow'), | ||
| ); | ||
| $form = $this->createFormBuilder($defaults) |
There was a problem hiding this comment.
Ah yes forgot about my comment, this is a good fix!
| thx |
| Thank you @matthieu88160. |
xabbuh added a commit that referenced this pull request Mar 13, 2017
…eu88160) This PR was submitted for the 3.2 branch but it was merged into the 2.7 branch instead (closes #7560). Discussion ---------- Resolving $this usage outside a class on form.rst This commit take care of the framework use code examples only. The "Creating a simple Form" define the coding place to be into a controller action method. Unlikely, the documentation consider into the other examples that the reader will know the place of the sample code. This does not allow the examples to be standalone and can lead some disappointment for which one want to have informations about a single section. This commit offer to place the code samples into the default controller to create a logic use of the "$this" special variable. Commits ------- 8cf9cd2 Resolving $this usage outside a class on form.rst
xabbuh added a commit that referenced this pull request Mar 13, 2017
xabbuh added a commit that referenced this pull request Mar 13, 2017
* 2.7: (30 commits) [#7560] remove unused use statements Resolving $this usage outside a class on form.rst Fix some odd English in the PDOSessionHandler docs Fix typo Add the description for the HTTP status because it's not that common Update exception code status [#7592] some minor tweaks Fix link for Twig Extensions documentation Update framework.rst [Fix esi tag] Update render_without_controller.rst Update matchers.rst Update matchers.rst Update locale_sticky_session.rst Update framework.rst Update import.rst Update load_balancer_reverse_proxy.rst Moved the requirements file [#7509] add missing references Added a mention to APCu Polyfill in the performance article [#7497] minor rewording ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This commit take care of the framework use code examples only.
The "Creating a simple Form" define the coding place to be into a controller action method. Unlikely, the documentation consider into the other examples that the reader will know the place of the sample code. This does not allow the examples to be standalone and can lead some disappointment for which one want to have informations about a single section.
This commit offer to place the code samples into the default controller to create a logic use of the "$this" special variable.