Twig Extension does no longer need getName() method #7523
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This has been deprecated as of Twig 1.26, see https://github.com/twigphp/Twig/blob/v1.26.0/CHANGELOG#L7
xabbuh reviewed Feb 23, 2017
templating/twig_extension.rst Outdated
| | ||
| .. note:: | ||
| | ||
| Prior to Twig 1.26, your extension had to provide an additional `getName` method that |
There was a problem hiding this comment.
We need double backticks here for the reStructuredText format.
| 👍 Status: Reviewed |
xabbuh reviewed Feb 27, 2017
templating/twig_extension.rst Outdated
| } | ||
| } | ||
| | ||
| .. note::.. note:: |
There was a problem hiding this comment.
You probably do not want to double the note. ;)
| Thank you @mpdude. |
xabbuh added a commit that referenced this pull request Feb 28, 2017
…de, javiereguiluz) This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #7523). Discussion ---------- Twig Extension does no longer need getName() method This has been deprecated as of Twig 1.26, see https://github.com/twigphp/Twig/blob/v1.26.0/CHANGELOG#L7 Commits ------- f94fd8f Fixed a syntax issue 200683e Minor change c59a8d5 Fix .rst formatting 00f36bb Twig Extension does no longer need getName() method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This has been deprecated as of Twig 1.26, see https://github.com/twigphp/Twig/blob/v1.26.0/CHANGELOG#L7