Skip to content

Conversation

@20uf
Copy link
Contributor

@20uf 20uf commented Feb 22, 2017

Hi,

Continuation of the PR #7395 for the 2.7 branch.

Regards,

Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Status: reviewed

@javiereguiluz
Copy link
Member

Note to mergers: to be merged only in 2.7 and 2.8; not in 3.x branches.

@20uf
Copy link
Contributor Author

20uf commented Feb 23, 2017

@javiereguiluz,

We have an error on build:

... writing output... [100%] validation/translations Warning, treated as error: /home/travis/build/symfony/symfony-docs/service_container/parameters.rst:254: WARNING: unknown document: Expression Language component /components/expression_language

What I do not reproduce locally

cd _build && make html ... writing output... [100%] service_container/parameters generating indices... genindex writing additional pages... search copying static files... done copying extra files... done dumping search index in English (code: en) ... done dumping object inventory... done build succeeded.

An idea ?

@javiereguiluz
Copy link
Member

@20uf yes! I made a mistake when writing the link to the document. See that the :doc: syntax is different when you want to customize the label of the link. Hopefully it's fixed now!

@20uf
Copy link
Contributor Author

20uf commented Feb 23, 2017

Thank you @javiereguiluz

Copy link
Contributor

@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition, thanks!

@xabbuh xabbuh merged commit 1dc3913 into symfony:2.7 Feb 28, 2017
xabbuh added a commit that referenced this pull request Feb 28, 2017
…ion language] (20uf, javiereguiluz) This PR was merged into the 2.7 branch. Discussion ---------- [DependencyInjection][Improve] Constant YAML with expression language] Hi, Continuation of the PR #7395 for the 2.7 branch. Regards, Commits ------- 1dc3913 Fixed the RST syntax 6d0de9d Minor rewords 79191bf [DependencyInjection][Improve] Constant YAML with expression language]
@xabbuh
Copy link
Member

xabbuh commented Feb 28, 2017

Thank you @20uf.

@20uf 20uf deleted the improve/constant-yaml-with-expression-language branch March 2, 2017 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment