[ExpressionLanguage] Document ExpressionFunction::fromPhp #7517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
xabbuh reviewed Feb 21, 2017
| | ||
| ExpressionFunction::fromPhp('strtoupper'); | ||
| | ||
| It allows namespaced PHP function where second parameter must be defined to name expression:: |
| Please also add a .. versionadded:: 3.3 The ``ExpressionFunction::fromPhp()`` method was introduced in Symfony 3.3. |
| 👍 Status: Reviewed |
| Result:
|
| @maidmaid This should work. The template used to render the preview is not exactly the same as the one used on symfony.com (we don't update it every time small changes are made to the website). |
| Cool, thank you for your reviews :) |
HeahDude reviewed Feb 27, 2017
| .. tip:: | ||
| | ||
| You can create an expression function from a PHP function with the |
There was a problem hiding this comment.
"You can create ..." => "To create ..."
| Thank you @maidmaid. |
xabbuh added a commit that referenced this pull request Feb 28, 2017
…hp (maidmaid, javiereguiluz) This PR was merged into the master branch. Discussion ---------- [ExpressionLanguage] Document ExpressionFunction::fromPhp cf symfony/symfony#21122 Commits ------- 415c4ec Update extending.rst 478400a Minor reword 059155f Add versionadded 6c9e09d Fix typo c70ea7f Fix typo 6d9af37 Add fromPhp tip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
cf symfony/symfony#21122