[Requirements] Clarify what are JSON and ctype #7498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Thank you @alexislefebvre. |
xabbuh added a commit that referenced this pull request Mar 3, 2017
…ebvre, javiereguiluz) This PR was merged into the 2.7 branch. Discussion ---------- [Requirements] Clarify what are JSON and ctype On: http://symfony.com/doc/2.7/reference/requirements.html#required I found “*JSON needs to be enabled*” and “*ctype needs to be enabled*” ambiguous, the first may be misinterpreted as a browser need and the second as a C dependency. I added “*extension*” and links to the official PHP documentation. After the update, these items will look like this: > - [JSON extension](http://php.net/manual/book.json.php) needs to be enabled > - [ctype extension](http://php.net/manual/book.ctype.php) needs to be enabled Commits ------- 75bc678 Use https URLs when possible 43e45ac [Requirements] Clarify what are JSON and ctype
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
On: http://symfony.com/doc/2.7/reference/requirements.html#required
I found “JSON needs to be enabled” and “ctype needs to be enabled” ambiguous, the first may be misinterpreted as a browser need and the second as a C dependency.
I added “extension” and links to the official PHP documentation.
After the update, these items will look like this: