Minor fix in postLoad event (file uploading) #7494
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…s in FileUploader class to make it possible to get $targetDir from outside.
Simperfit reviewed Feb 16, 2017
controller/upload_file.rst Outdated
| return $this->targetDir; | ||
| } | ||
| | ||
| public function setTargetDir($targetDir = '') |
There was a problem hiding this comment.
Fair observation. Perhaps it would be better to move default empty string to property declaration?
There was a problem hiding this comment.
I would just remove the setter. IMO there's no need to have it. We only need the getter to be able to read the configured directory later.
xabbuh approved these changes Feb 27, 2017
| Thank you @icamys. |
xabbuh added a commit that referenced this pull request Feb 28, 2017
… Dmitrii) This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #7494). Discussion ---------- Minor fix in `postLoad` event (file uploading) Minor fix in `postLoad` event (file uploading). Added accessor methods in FileUploader class to make it possible to get $targetDir from outside. Commits ------- f16d3ed Minor fix in event (file uploading)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Minor fix in
postLoadevent (file uploading). Added accessor methods in FileUploader class to make it possible to get $targetDir from outside.