note to make sure user's overriding bundle is registered #7062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
javiereguiluz approved these changes Nov 21, 2016
There was a problem hiding this comment.
@kshishkin I agree with your proposal ... but I didn't like your solution because adding a Note looked like too much to me (we try to minimize notes/tips/cautions because the break the reading flow).
I've proposed another way to explain this. If you don't agree, please tell us. Thanks!
xabbuh reviewed Nov 22, 2016
bundles/inheritance.rst Outdated
| its controllers. Suppose also that you have your own UserBundle where you want | ||
| the overridden files to live. Start by registering the FOSUserBundle as the | ||
| "parent" of your bundle:: | ||
| For example, suppose that you have installed `FOSUserBundle`_ but you want to |
| Thank you @kshishkin. |
xabbuh added a commit that referenced this pull request Nov 28, 2016
…(kshishkin, javiereguiluz) This PR was merged into the 2.7 branch. Discussion ---------- note to make sure user's overriding bundle is registered Commits ------- c73bf94 Added missing comma 9351233 Reword the introduction to the article 59c4299 note to make sure user's overriding bundle is registered
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.