[Validator] Add shorter examples using the default option #6597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
alexmart commented May 21, 2016
alexmart commented | Q | A |
|---|---|
| Doc fix? | no |
| New docs? | no |
| Applies to | >= 2.3 |
| Fixed tickets | #4144 |
alexmart changed the title 
reference/constraints/Type.rst Outdated
| | ||
| .. configuration-block:: | ||
| | ||
| .. code-block:: php-annotations |
There was a problem hiding this comment.
I think you can still use the "default" option version - i.e.:
/** * @Assert\Type("integer", message="The value..") */Obviously, this doesn't apply to all formats (like YAML)
| I made some new changes. Already spotted some formatting mistakes. @weaverryan regarding your previous comment, should I add the message part for the simple examples? I thought the idea is to show the simplest thing that works. |
alexmart changed the title 
| than ``18``, you could do the following: | ||
| The following constraints ensure that: | ||
| - the number of ``siblings`` of a ``Person`` is greater than ``5`` | ||
| - the ``age`` of a ``Person`` class is greater than ``18`` |
There was a problem hiding this comment.
we commonly use * as list indicator (can be fixed during the merge though)
| 👍 I like it a lot Status: Reviewed |
| If you want to ensure that the ``age`` of a ``Person`` class is greater | ||
| than ``18``, you could do the following: | ||
| The following constraints ensure that: | ||
| - the number of ``siblings`` of a ``Person`` is greater than ``5`` |
There was a problem hiding this comment.
Please leave a blank line before the list items. Otherwise, it will be displayed like this:
xabbuh added a commit that referenced this pull request Jun 30, 2016
… (alexmart) This PR was submitted for the 2.3 branch but it was merged into the 2.7 branch instead (closes #6597). Discussion ---------- [Validator] Add shorter examples using the default option | Q | A | ------------- | --- | Doc fix? | no | New docs? | no | Applies to | >= 2.3 | Fixed tickets | #4144 Commits ------- d3cde84 [Validator] Add shorter examples using the default option
xabbuh added a commit that referenced this pull request Jun 30, 2016
* 2.7: [#6597] some tweaks [Validator] Add shorter examples using the default option Typo fix Updated the CS rule about return null; and return; Update date.rst - Fixes typo NullOutput should be passed to $command->run() Hard values for the driver option
xabbuh added a commit that referenced this pull request Jun 30, 2016
* 2.8: [#6597] some tweaks [Validator] Add shorter examples using the default option Typo fix Add missing parameter Updated the CS rule about return null; and return; [#6690] fix syntax error Update date.rst - Fixes typo [#6690] add versionadded directive Added an example for a different method of verbosity level usage. NullOutput should be passed to $command->run() Hard values for the driver option Fix ldap security examples
xabbuh added a commit that referenced this pull request Jun 30, 2016
* 3.0: [#6597] some tweaks [Validator] Add shorter examples using the default option Typo fix Add missing parameter Updated the CS rule about return null; and return; [#6690] fix syntax error Update date.rst - Fixes typo [#6690] add versionadded directive Added an example for a different method of verbosity level usage. NullOutput should be passed to $command->run() Hard values for the driver option Fix ldap security examples
xabbuh added a commit that referenced this pull request Jun 30, 2016
* 3.1: [#6597] some tweaks [Validator] Add shorter examples using the default option Typo fix Added the documentation for the Cache component Add missing parameter Updated the CS rule about return null; and return; [#6690] fix syntax error Update date.rst - Fixes typo [#6690] add versionadded directive Added an example for a different method of verbosity level usage. NullOutput should be passed to $command->run() Hard values for the driver option Fix ldap security examples
chancegarcia pushed a commit to chancegarcia/symfony-docs that referenced this pull request Jul 2, 2016
| Thanks everybody for helping me with my first contribution! |
| @alexmart We are happy to have you onboard. Hope we see you again with some other nice contribution. :) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.